Parallel Test for SQL - Simultaneous read operations - #786
Merged
Shyam Sundar J (severussundar) merged 9 commits intoSep 9, 2022
Conversation
Shyam Sundar J (severussundar)
marked this pull request as ready for review
September 7, 2022 13:54
Shyam Sundar J (severussundar)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Aaron Powell (aaronpowell),
Abhishek Kumar (abhishekkumams),
Ayush Agarwal (ayush3797),
Gledis Zeneli (gledis69),
Jarupat Jisarojito (jarupatj),
Jun Su (junsu0ms),
Bhaskar Mallapragada (mbhaskar),
Milis (milismsft),
Sean Leonard (seantleonard) and
tarazou9
as code owners
September 7, 2022 13:54
aaronburtle
reviewed
Sep 8, 2022
aaronburtle
reviewed
Sep 8, 2022
aaronburtle
approved these changes
Sep 8, 2022
aaronburtle
left a comment
aaronburtle
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for adding in parallel testing.
Aniruddh Munde (Aniruddh25)
approved these changes
Sep 9, 2022
Aniruddh Munde (Aniruddh25)
left a comment
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! with a few nit fixes
…om/Azure/data-api-builder into dev/shyamsundarj/concurrent-test-1
Shyam Sundar J (severussundar)
deleted the
dev/shyamsundarj/concurrent-test-1
branch
September 9, 2022 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?
The test script was run locally against dab
Test Results:
In the below screenshot,
checksis the only relevant field for this test. Other fields are applicable only for performance tests such as load, stress tests etc.